Skip Menu |
 

This queue is for tickets about the Dist-Zilla-Plugin-CopyFilesFromBuild CPAN distribution.

Report information
The Basics
Id: 92828
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-CopyFilesFromBuild

People
Owner: Nobody in particular
Requestors: NGLENN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: dzil dies when files are added multiple times
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-14312-1391817596-282.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 749
Download (untitled) / with headers
text/plain 749b
I happily used this module to copy a README, LICENSE, and cpanfile into my project root. However, the next time I ran dzil build, dzil died because it grabbed the files from the project root and then tried to add them again through this plugin. Here are the messages I got: [DZ] attempt to add cpanfile multiple times; added by: GatherDir (Dist::Zilla::Plugin::GatherDir line 100); CPANFile (Dist::Zilla::Plugin::CPANFile line 65) [DZ] attempt to add LICENSE multiple times; added by: GatherDir (Dist::Zilla::Plugin::GatherDir line 100); License (Dist::Zilla::Plugin::License line 22) [DZ] attempt to add Makefile.PL multiple times; added by: GatherDir (Dist::Zilla::Plugin::GatherDir line 100); MakeMaker (Dist::Zilla::Plugin::MakeMaker line 25 2)
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-14312-1391817596-282.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-14312-1391817596-282.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-25930-1391818124-88.92828-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 990
Download (untitled) / with headers
text/plain 990b
On Fri Feb 07 18:59:56 2014, NGLENN wrote: Show quoted text
> I happily used this module to copy a README, LICENSE, and cpanfile > into my project root. However, the next time I ran dzil build, dzil > died because it grabbed the files from the project root and then tried > to add them again through this plugin. Here are the messages I got: > > [DZ] attempt to add cpanfile multiple times; added by: GatherDir > (Dist::Zilla::Plugin::GatherDir line 100); CPANFile > (Dist::Zilla::Plugin::CPANFile line 65) > [DZ] attempt to add LICENSE multiple times; added by: GatherDir > (Dist::Zilla::Plugin::GatherDir line 100); License > (Dist::Zilla::Plugin::License line 22) > [DZ] attempt to add Makefile.PL multiple times; added by: GatherDir > (Dist::Zilla::Plugin::GatherDir line 100); MakeMaker > (Dist::Zilla::Plugin::MakeMaker line 25 > 2)
Maybe dzil was modified to disallow adding the same file twice? The only solution I can think of is to add these files to the "exclude_filename" option of GatherDir.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-25930-1391818124-88.92828-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-14312-1391817596-282.0-0-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391818124-88.92828-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-16831-1391819628-1059.92828-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 663
Download (untitled) / with headers
text/plain 663b
On 2014-02-07 16:08:44, RTHOMPSON wrote: Show quoted text
> Maybe dzil was modified to disallow adding the same file twice? The > only solution I can think of is to add these files to the > "exclude_filename" option of GatherDir.
You're right on both counts - you can't add a file twice, by any mechanism, and you're both gathering the existing file in the repo (by [GatherDir] or [Git::GatherDir]) as well as [ReadmeAnyFromPod] attempting to create a new one. The answer indeed is to tell GatherDir to skip this file. e.g. see what I'm doing here: https://metacpan.org/source/ETHER/Dist-Zilla-PluginBundle-Author-ETHER-0.049/lib/Dist/Zilla/PluginBundle/Author/ETHER.pm#L332
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-16831-1391819628-1059.92828-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-14312-1391817596-282.0-0-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391818124-88.92828-0-0 [...] rt.cpan.org> <rt-4.0.18-16831-1391819628-1059.92828-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-25930-1391819819-628.92828-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 934
Download (untitled) / with headers
text/plain 934b
On Fri Feb 07 19:33:49 2014, ETHER wrote: Show quoted text
> On 2014-02-07 16:08:44, RTHOMPSON wrote: >
> > Maybe dzil was modified to disallow adding the same file twice? The > > only solution I can think of is to add these files to the > > "exclude_filename" option of GatherDir.
> > > You're right on both counts - you can't add a file twice, by any > mechanism, and you're both gathering the existing file in the repo (by > [GatherDir] or [Git::GatherDir]) as well as [ReadmeAnyFromPod] > attempting to create a new one. The answer indeed is to tell > GatherDir to skip this file. > > e.g. see what I'm doing here: > > https://metacpan.org/source/ETHER/Dist-Zilla-PluginBundle-Author- > ETHER-0.049/lib/Dist/Zilla/PluginBundle/Author/ETHER.pm#L332
Semi-unrelated question: what's the difference between CopyFileFromBuild and CopyFilesFromRelease? I guess the latter only triggers when you actually make a release instead of on every build?
From garfieldnate [...] gmail.com Fri Feb 7 19: 42:47 2014
CC: NGLENN [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-2.698 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-25930-1391819819-824.92828-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-92828 [...] rt.cpan.org> <rt-4.0.18-14312-1391817596-282.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391818124-88.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-16831-1391819628-1059.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391819819-824.92828-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.58.188.78 with SMTP id fy14mr12947525vec.23.1391820155058; Fri, 07 Feb 2014 16:42:35 -0800 (PST)
Message-ID: <CACs83pj8PRUiqRszVjjkt=eWAy7LhzA7u+F_phsmJjr+eXKO7A [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="089e013a12f0ef006d04f1da61c3"
X-Spam-Score: -2.698
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 66461240EF4 for <cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com>; Fri, 7 Feb 2014 19:42:47 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RKd-cAG7OepY for <cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com>; Fri, 7 Feb 2014 19:42:46 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id C2407240F18 for <bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org>; Fri, 7 Feb 2014 19:42:45 -0500 (EST)
Received: (qmail 13606 invoked by alias); 8 Feb 2014 00:42:45 -0000
Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Feb 2014 16:42:39 -0800
Received: by mail-vc0-f169.google.com with SMTP id hq11so3199884vcb.14 for <bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org>; Fri, 07 Feb 2014 16:42:35 -0800 (PST)
Received: by 10.220.184.135 with HTTP; Fri, 7 Feb 2014 16:42:35 -0800 (PST)
Delivered-To: cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #92828] dzil dies when files are added multiple times
Return-Path: <garfieldnate [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Nsz5OcVUFEuK/hbHuh2yaDOrF1nIizywxCeaoJYoGRs=; b=nJZiZGoDz5/ASU/qtZBkgpMClXwoP0sLYFy/2PPUMBry5y35RTA2ImFJHsy4mbb8SB Psg0RZEi7rKnVAnTFAYlcekhX3zw2BP5hI2J2L3cHsZxix9VpkzaKDMylgJYBq6Z5fSn uKNMO91q47bKDJ9CaELuO15jVIB1pC0jaJHi9H+m8aqIiwQ1BoEqe6bviFDieXHJNZML BRiQxSVTS/Mh1lGu445+QhAp2gtj3RQMC3ugQzLdYHYswTscuOVSOyPskC7QeA4aPH8x pQtIJAydMUSR49MRfAxACWty7DhBfgWnPdtnTO892IxLQkLKafB7o+m+B0GFy+4Jjz8m wkMw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla-plugin-copyfilesfrombuild
Date: Fri, 7 Feb 2014 16:42:35 -0800
X-Spam-Level:
To: bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org
From: Nathan Glenn <garfieldnate [...] gmail.com>
RT-Message-ID: <rt-4.0.18-5240-1391820168-912.92828-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1481
Download (untitled) / with headers
text/plain 1.4k
Thanks Karen. That does fix the problem but it violates DRY. Now if I change the settings for one plugin I also have to change them for the other. I'm not sure what the diff is between this and that other plugin... I think a simple "clobber" or "write_over" or "replace" = 1 option would be very helpful for this plugin. On Fri, Feb 7, 2014 at 4:36 PM, Ryan C. Thompson via RT < bug-Dist-Zilla-Plugin-CopyFilesFromBuild@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=92828 > > > On Fri Feb 07 19:33:49 2014, ETHER wrote:
> > On 2014-02-07 16:08:44, RTHOMPSON wrote: > >
> > > Maybe dzil was modified to disallow adding the same file twice? The > > > only solution I can think of is to add these files to the > > > "exclude_filename" option of GatherDir.
> > > > > > You're right on both counts - you can't add a file twice, by any > > mechanism, and you're both gathering the existing file in the repo (by > > [GatherDir] or [Git::GatherDir]) as well as [ReadmeAnyFromPod] > > attempting to create a new one. The answer indeed is to tell > > GatherDir to skip this file. > > > > e.g. see what I'm doing here: > > > > https://metacpan.org/source/ETHER/Dist-Zilla-PluginBundle-Author- > > ETHER-0.049/lib/Dist/Zilla/PluginBundle/Author/ETHER.pm#L332
> > > Semi-unrelated question: what's the difference between CopyFileFromBuild > and CopyFilesFromRelease? I guess the latter only triggers when you > actually make a release instead of on every build? >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2229
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-5240-1391820168-912.92828-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-92828 [...] rt.cpan.org> <rt-4.0.18-14312-1391817596-282.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391818124-88.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-16831-1391819628-1059.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391819819-824.92828-6-0 [...] rt.cpan.org> <CACs83pj8PRUiqRszVjjkt=eWAy7LhzA7u+F_phsmJjr+eXKO7A [...] mail.gmail.com> <rt-4.0.18-5240-1391820168-912.92828-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1928-1391820486-1919.92828-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 2260
Download (untitled) / with headers
text/plain 2.2k
On Fri Feb 07 19:42:48 2014, garfieldnate@gmail.com wrote: Show quoted text
> Thanks Karen. That does fix the problem but it violates DRY. Now if I > change the settings for one plugin I also have to change them for the other. > I'm not sure what the diff is between this and that other plugin... > > I think a simple "clobber" or "write_over" or "replace" = 1 option would be > very helpful for this plugin. > > > On Fri, Feb 7, 2014 at 4:36 PM, Ryan C. Thompson via RT < > bug-Dist-Zilla-Plugin-CopyFilesFromBuild@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=92828 > > > > > On Fri Feb 07 19:33:49 2014, ETHER wrote:
> > > On 2014-02-07 16:08:44, RTHOMPSON wrote: > > >
> > > > Maybe dzil was modified to disallow adding the same file twice? The > > > > only solution I can think of is to add these files to the > > > > "exclude_filename" option of GatherDir.
> > > > > > > > > You're right on both counts - you can't add a file twice, by any > > > mechanism, and you're both gathering the existing file in the repo (by > > > [GatherDir] or [Git::GatherDir]) as well as [ReadmeAnyFromPod] > > > attempting to create a new one. The answer indeed is to tell > > > GatherDir to skip this file. > > > > > > e.g. see what I'm doing here: > > > > > > https://metacpan.org/source/ETHER/Dist-Zilla-PluginBundle-Author- > > > ETHER-0.049/lib/Dist/Zilla/PluginBundle/Author/ETHER.pm#L332
> > > > > > Semi-unrelated question: what's the difference between CopyFileFromBuild > > and CopyFilesFromRelease? I guess the latter only triggers when you > > actually make a release instead of on every build? > >
The problem is that the CopyFilesFromBuild plugin is not directly involved with the problem, so there is nothing that it can do directly to fix it. This is why you have to violate DRY and manually tell the GatherDir plugin to exclude the files. The only other solution I can think of is rather messy: The CopyFilesFromBuild plugin would have to arrange for itself to run before the GatherDir plugin, and it would have to modify the GatherDir plugin's options to add the appropriate file exclusions. And then the solution only works for the GatherDir plugin and not any alternative plugin that one might use that would accidentally add the files.
From garfieldnate [...] gmail.com Fri Feb 7 20: 09:32 2014
CC: NGLENN [...] cpan.org
MIME-Version: 1.0
X-Spam-Status: No, score=-2.698 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
In-Reply-To: <rt-4.0.18-1928-1391820486-318.92828-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-92828 [...] rt.cpan.org> <rt-4.0.18-14312-1391817596-282.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391818124-88.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-16831-1391819628-1059.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-25930-1391819819-824.92828-6-0 [...] rt.cpan.org> <CACs83pj8PRUiqRszVjjkt=eWAy7LhzA7u+F_phsmJjr+eXKO7A [...] mail.gmail.com> <rt-4.0.18-5240-1391820168-912.92828-6-0 [...] rt.cpan.org> <rt-4.0.18-1928-1391820486-318.92828-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.52.171.39 with SMTP id ar7mr10686610vdc.5.1391821762278; Fri, 07 Feb 2014 17:09:22 -0800 (PST)
Message-ID: <CACs83piE8ZXiR8vvn=o=S5zPejvbzHLt0ADWu8SENNSDmAbtFw [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="047d7bacb738bb390b04f1dac1b6"
X-Spam-Score: -2.698
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6D730240F18 for <cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com>; Fri, 7 Feb 2014 20:09:32 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2HQDtC7dcM5b for <cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com>; Fri, 7 Feb 2014 20:09:31 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B9E45240EF4 for <bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org>; Fri, 7 Feb 2014 20:09:30 -0500 (EST)
Received: (qmail 14880 invoked by alias); 8 Feb 2014 01:09:29 -0000
Received: from mail-vb0-f54.google.com (HELO mail-vb0-f54.google.com) (209.85.212.54) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 07 Feb 2014 17:09:27 -0800
Received: by mail-vb0-f54.google.com with SMTP id w20so3180917vbb.41 for <bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org>; Fri, 07 Feb 2014 17:09:22 -0800 (PST)
Received: by 10.220.184.135 with HTTP; Fri, 7 Feb 2014 17:09:22 -0800 (PST)
Delivered-To: cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #92828] dzil dies when files are added multiple times
Return-Path: <garfieldnate [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=DvFsGQEsirn8AF/qEXfVrQXx/woPzLbEhx1Ii/iAOJA=; b=uBzwmMo3BCma/hCrFYhsy1RbpN7ElQkRQuuZk7L2aOeIJqwCrPmuTODKG1E7LfzNNn ZwvaZ3PRJkv8Zy2sQ5KcwNZdZD/L6CqvlsdD3P6g/5uz3ON0deiXNCeeV3m0weLYNqce ZUPqPhSUDbnsjirDfaB1QRrJ80FIkbpEAiCW3SREXitmcNSwZ3Nbs/bOGANoALtjk/EP g44HR8IG3I/zgaZK0G3849xlDfGZi8RVC4MpoCfv8QbIkvTjVczlhWX/AK4kX0437LJe b+SOtb5MzFHSqchht4Qv3tmVuYgJgzhyIVxrSkQFbP1YhisAjkIzSEcpLKNoIuvo0wVD 107g==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Dist-Zilla-Plugin-CopyFilesFromBuild [...] hipster.bestpractical.com
X-RT-Mail-Extension: dist-zilla-plugin-copyfilesfrombuild
Date: Fri, 7 Feb 2014 17:09:22 -0800
X-Spam-Level:
To: bug-Dist-Zilla-Plugin-CopyFilesFromBuild [...] rt.cpan.org
From: Nathan Glenn <garfieldnate [...] gmail.com>
RT-Message-ID: <rt-4.0.18-16831-1391821773-813.92828-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 2785
Download (untitled) / with headers
text/plain 2.7k
Darn. There's probably not a phase between "gather existing files" and "generate some more files", because the role for this would have to be run in between those two, deleting files from the first before they could be added in the second. On Fri, Feb 7, 2014 at 4:48 PM, Ryan C. Thompson via RT < bug-Dist-Zilla-Plugin-CopyFilesFromBuild@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=92828 > > > On Fri Feb 07 19:42:48 2014, garfieldnate@gmail.com wrote:
> > Thanks Karen. That does fix the problem but it violates DRY. Now if I > > change the settings for one plugin I also have to change them for the
> other.
> > I'm not sure what the diff is between this and that other plugin... > > > > I think a simple "clobber" or "write_over" or "replace" = 1 option would
> be
> > very helpful for this plugin. > > > > > > On Fri, Feb 7, 2014 at 4:36 PM, Ryan C. Thompson via RT < > > bug-Dist-Zilla-Plugin-CopyFilesFromBuild@rt.cpan.org> wrote: > >
> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=92828 > > > > > > > On Fri Feb 07 19:33:49 2014, ETHER wrote:
> > > > On 2014-02-07 16:08:44, RTHOMPSON wrote: > > > >
> > > > > Maybe dzil was modified to disallow adding the same file twice? The > > > > > only solution I can think of is to add these files to the > > > > > "exclude_filename" option of GatherDir.
> > > > > > > > > > > > You're right on both counts - you can't add a file twice, by any > > > > mechanism, and you're both gathering the existing file in the repo
> (by
> > > > [GatherDir] or [Git::GatherDir]) as well as [ReadmeAnyFromPod] > > > > attempting to create a new one. The answer indeed is to tell > > > > GatherDir to skip this file. > > > > > > > > e.g. see what I'm doing here: > > > > > > > > https://metacpan.org/source/ETHER/Dist-Zilla-PluginBundle-Author- > > > > ETHER-0.049/lib/Dist/Zilla/PluginBundle/Author/ETHER.pm#L332
> > > > > > > > > Semi-unrelated question: what's the difference between
> CopyFileFromBuild
> > > and CopyFilesFromRelease? I guess the latter only triggers when you > > > actually make a release instead of on every build? > > >
> > The problem is that the CopyFilesFromBuild plugin is not directly involved > with the problem, so there is nothing that it can do directly to fix it. > This is why you have to violate DRY and manually tell the GatherDir plugin > to exclude the files. The only other solution I can think of is rather > messy: The CopyFilesFromBuild plugin would have to arrange for itself to > run before the GatherDir plugin, and it would have to modify the GatherDir > plugin's options to add the appropriate file exclusions. And then the > solution only works for the GatherDir plugin and not any alternative plugin > that one might use that would accidentally add the files. >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 3942


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.